LearnNewsExamplesServices
Frontmatter
id18089
titleThe reveal-pin screenshot baselines predate the inline-header trim, so DockPinCollapseNL is red on dev
stateClosed
labels
bug
assigneesneo-fable
createdAtSep 2, 2026, 3:22 PM
updatedAtSep 2, 2026, 4:21 PM
githubUrlhttps://github.com/neomjs/neo/issues/18089
authorneo-fable
commentsCount0
parentIssue13158
subIssues[]
subIssuesCompleted0
subIssuesTotal0
contentTrust
projected
quarantined0
signals[]
blockedBy[]
blocking[]
closedAtSep 2, 2026, 4:21 PM

The reveal-pin screenshot baselines predate the inline-header trim, so DockPinCollapseNL is red on dev

neo-fable
neo-fable commented on Sep 2, 2026, 3:22 PM

Problem

test/playwright/e2e/dashboard/DockPinCollapseNL.spec.mjs holds eight darwin baselines under DockPinCollapseNL.spec.mjs-snapshots/reveal-pin-<theme>-{enabled,disabled}-chromium-darwin.png (four themes × two states), asserting the reveal pin stays compact and legible per theme. #18048 (merged this morning) changed how the inline header renders — the title weight moved to the tab and the header trimmed — so the overlay header the arms screenshot no longer matches the stored images. The arms are red on plain dev for the baselines' reason, not the product's; the five-beat journey and the rest of the dock e2e suite pass (defect-noted on the A2A channel at 12:32Z).

Evidence

  • Snapshot directory: test/playwright/e2e/dashboard/DockPinCollapseNL.spec.mjs-snapshots/ — eight reveal-pin-* files, all darwin.
  • The screenshot arms: DockPinCollapseNL.spec.mjs at the toHaveScreenshot calls inside "the reveal pin is compact and legible under ".
  • The change that aged them out: #18048 (tab owns the title weight; inline header trimmed).

Change

Re-record the eight baselines on darwin with the e2e config and the Brain runtime root (--update-snapshots), commit only the images, and confirm the spec is green against the new files twice. No product or spec-logic change.

Acceptance Criteria

  • The eight reveal-pin-* darwin images are regenerated from current dev; the PR diff is images only.
  • DockPinCollapseNL.spec.mjs passes twice in a row locally against the new baselines (e2e config, Brain root).
  • The PR body names the head the images were recorded at.

Non-goals

  • Linux baselines (none exist for these arms; CI does not run the screenshot arms).
  • Any change to the reveal header's rendering.

Sweep 13:14–13:19Z before filing: live latest-20 open (no match), A2A last-12 (no match), Knowledge Base (no leaf).

Authored by Mnemosyne (@neo-fable, Claude Fable 5.1, Claude Code) · session 37bbc610-f0cd-4abb-95c2-eb70336a86f3