LearnNewsExamplesServices
Frontmatter
id19413
titleThe claim responder counts a pull request inside a contributor's fork as a hold
stateClosed
labels
bugai
assigneesneo-opus-grace
createdAtOct 5, 2026, 4:24 PM
updatedAtOct 6, 2026, 1:08 PM
githubUrlhttps://github.com/neomjs/neo/issues/19413
authorneo-opus-grace
commentsCount0
parentIssuenull
subIssues[]
subIssuesCompleted0
subIssuesTotal0
contentTrust
projected
quarantined0
signals[]
blockedBy[]
blocking[]
closedAtOct 6, 2026, 1:08 PM

The claim responder counts a pull request inside a contributor's fork as a hold

neo-opus-grace
neo-opus-grace commented on Oct 5, 2026, 4:24 PM

Context

From Ada's defect-note a8c88df9 (2026-10-05). On #19230 a first-time Hacktoberfest claimant, Saadanjum01, got the reply "This one is taken: #1 is open for it." That #1 was Saadanjum0/neo#1, a draft pull request inside a fork, whose base is Saadanjum0/neo:dev. Ada corrected the reply on the thread and assigned the issue.

The Problem

.github/workflows/claim-responder.yml reads the issue's closedByPullRequestsReferences and passes every open one as {number, author}. buildScripts/util/claimResponse.mjs#holders then counts each as a hold, unless the claimant authored it. A pull request inside a fork that mentions the issue is not a pull request into this repository, but it is counted anyway. It is also printed as a bare #1, which here names an unrelated pull request.

The Fix

  • The workflow also reads the pull request's repository { nameWithOwner }, which is its base repository, and passes it on.
  • holders counts an open pull request only when its repository is the one the reply is for, which it reads from repoUrl. A pull request from a fork into this repository still counts, because its base is this repository.

Acceptance Criteria

  • A pull request inside a fork holds nothing, so the claimant is first in line. A spec arm reproduces #19230's shape.
  • A pull request into this repository still holds the issue (the existing arms, now passing repository).
  • The workflow passes each pull request's repository.

Out of Scope

  • Wording of the reply.

Related: #19202 · #19230

Sweeps at 14:30Z:

  • Live latest-open: the latest 20 open issues; none equivalent.
  • A2A: Ada's defect-note and her note to me (fix and ticket are mine).
  • Own assignments: none on this surface.

Origin Session ID: 90464c20-910b-4abd-ac1d-d86f8fbccb13

Authored by Grace (Claude Opus 5.5, Claude Code) 🖖

tobiu referenced in commit 6f657db - "fix(ci): the claim responder counts only pull requests into this repository as holds (#19413) (#19414) on Oct 6, 2026, 1:08 PM
tobiu closed this issue on Oct 6, 2026, 1:08 PM